Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformulate ConservationChecker #419

Closed
5 tasks
Tracked by #358
LenkaNovak opened this issue Sep 14, 2023 · 1 comment
Closed
5 tasks
Tracked by #358

Reformulate ConservationChecker #419

LenkaNovak opened this issue Sep 14, 2023 · 1 comment
Assignees
@LenkaNovak
Labels
🍃 leaf Issue coupled to a PR
Milestone
O5.1.4 (coupler) ...

Comments

@LenkaNovak
Copy link
Collaborator

ConservationChecker is the last module dependent on component model specific data structures (e.g. integrator.u.... ).

  • remove dependencies on data structures in ConservationChecker module
  • apply in unit tests
  • apply in the AMIP driver

QA

  • no behaviour changes
  • negligible changes/ improvements on performance
@LenkaNovak LenkaNovak added the 🍃 leaf Issue coupled to a PR label Sep 14, 2023
This was referenced Sep 14, 2023
Closed
Closed
@juliasloan25
Copy link
Member

this is completed via #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LenkaNovak LenkaNovak

Labels
🍃 leaf Issue coupled to a PR
Projects
None yet
Milestone
O5.1.4 (coupler) Software Revamp for ...
Development

No branches or pull requests
2 participants
@LenkaNovak @juliasloan25