Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove @show in coupling loop #437

Closed
juliasloan25 opened this issue Sep 25, 2023 · 1 comment · Fixed by #526
Closed

remove @show in coupling loop #437

juliasloan25 opened this issue Sep 25, 2023 · 1 comment · Fixed by #526

Comments

@juliasloan25
Copy link
Member

This if statement in the coupling loop is meant to print the date only on the first of the month, but it prints the date every day and at each timestep.

If we change the condition to have == instead of >=, the date will only get printed on the first of the month, but it will still get printed at each timestep that falls on that day (which is better, but maybe still not ideal):

        if cs.dates.date[1] == cs.dates.date1[1]
            @show(cs.dates.date[1])
        end
@juliasloan25
Copy link
Member Author

Actually, this error was only coming up on my branch js/timemanager, which tests out the new ClimaUtilities.jl TimeManager module. The issue was coming from not correctly using the trigger_callback function defined there (I wasn't updating date1 with its return value)

@juliasloan25 juliasloan25 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant