Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discontinuous water runoff #484

Closed
LenkaNovak opened this issue Nov 1, 2023 · 2 comments
Closed

Fix discontinuous water runoff #484

LenkaNovak opened this issue Nov 1, 2023 · 2 comments
Assignees
Labels
🍃 leaf Issue coupled to a PR

Comments

@LenkaNovak
Copy link
Collaborator

This is likely to be fixed by applying dss to precipitation sources.

Screen Shot 2023-11-01 at 1 25 17 PM
@LenkaNovak
Copy link
Collaborator Author

We checked that this is already dss'd

applying

Ws_cpy = deepcopy(Y_lnd.Ws)
dss_buffer = ClimaCore.Spaces.create_dss_buffer(Ws_cpy)
ClimaCore.Spaces.weighted_dss!(Ws_cpy, dss_buffer)

resulted in no change (i.e. sum(Y_lnd.Ws .- Ws_cpy) = 0).

Note, most of the grid imprinting is seen over areas which are not integrated over land.

@LenkaNovak
Copy link
Collaborator Author

Some discontinuity expected due to 0M instantaneously translating onto the land variables.

There is also additional discontinuity due to plotting (here blown up to show range of [-1e-5, 0] of the same col. integrated rain field, same snapshot (after 100d) using both methods).

ClimaCorePlots (nonconservative interpolation):
Image

ClimaCoreTempestRemap (conservative interpolation to RLL, where a lot of the discontinuity within elements goes away):
Image

Conclusion: rain-derived variables behave within expected bounds. Thanks, @trontrytel, for your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 leaf Issue coupled to a PR
Projects
None yet
Development

No branches or pull requests

1 participant