-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use reference state in amip with diagnostic edmf longrun #641
Comments
@szy21 Here are some plots at the time of crash after three hours. The NaNs are coming from radiation (maybe related to the rrtmgp issue?) but there are other aspects we should address in this config to ensure the spin up is as smooth as possible. For example, the ocean albedo (atmos is now released for the more realistic version), air density is too low over topo (maybe this will get better with sim time though), initial land T is perhaps too warm, and roughness lengths over land and ocean should be adjusted to more realistic values. |
Oh, great, thank you! If it's NaNs in radiation we know how to fix it. It should be already fixed in the latest RRTMGP version. |
But this is still with Float64 radiation, I'm a bit surprised it could have issues too. Let's see if the latest RRTMGP version can fix it. |
Reopen it to track if we can change back |
This now runs to completion with the new update to ClimaAtmos and ClimaLand (see this build). ![]() Note the albedo hooks need still need to be added (see #660 ), but getting close. |
Thanks! I actually want to change |
It's still breaking after the update: https://buildkite.com/clima/climacoupler-longruns/builds/465#018e0aba-da1e-4b67-846b-1efe3742af3e. The latest climaatmos release should include all the radiation fixes, we should check if radiation still has NaNs. |
And this is with the ref_state set to true, right? Just a sec, is this using the latest main? And where does it break rn? (do you have the Build?) |
Yes, everything I have been talking about is with I start to think that there might be something wrong with the combination of reference state, topography, and edmf. Given that |
The error message shows that there is a negative number in sqrt in RRTMGP. I don't know if it's because the state is wrong or something inside RRTMGP. I'll look into it. |
Sounds good, thanks! And in atmos this combination of reference state, topography, and edmf? Even if we use the slab ocean? 🤔 |
No, we test edmf and topography separately in atmos as I think it makes more sense to have land with topography. But if this problem persists I can go back to aqualanet for testing. I did test ref state + no topo + edmf in coupler and it seems to work. I may add that to longrun if it’s consistently more stable. |
This seems to work now with a stronger sponge: https://buildkite.com/clima/climacoupler-longruns/builds/478#018e1c1b-f16e-47f7-b6b7-dbaa79d48de2. I just realized that we have been using a stronger sponge for topography runs in the atmos, but not for edmf runs. As the coupler jobs use the toml file in atmos I'm using the (weaker) one for edmf. So this might be it. I think it might be easier to just specify the coupler toml file. |
The amip target with diagnostic edmf longrun is currently failing in the most recent build. We should fix it soon. Maybe try increasing hyperdiffusion and/or sponge.
Edit: the simulation runs fine with
use_reference_state: false
, which is what we set now in the main. But it would be good to change back touse_reference_state: true
.The text was updated successfully, but these errors were encountered: