Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overwrite atmos albedo #653

Closed
6 tasks done
Tracked by #358
juliasloan25 opened this issue Feb 29, 2024 · 0 comments · Fixed by #702
Closed
6 tasks done
Tracked by #358

overwrite atmos albedo #653

juliasloan25 opened this issue Feb 29, 2024 · 0 comments · Fixed by #702
Assignees
Labels
🍃 leaf Issue coupled to a PR

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Feb 29, 2024

As of our update to ClimaAtmos v0.21.0 (PR), ClimaAtmos is using ConstantAlbedo, and it doesn't get updated in coupled runs. We want to overwrite this albedo in the coupler with the albedo provided by the land model

Diffuse and direct albedo will also be needed bu the Big leaf model, so we implement a more general solution here.

Screen Shot 2024-03-19 at 9 36 38 AM
  • modify docs

Components of the implementation

  • 2 new coupler fields for albedo_direct and albedo_diffuse, as well as in the stub models
  • generalize the get_field functions to these two types of albedo
  • 2 new temp fields for dynamic calculations, avoiding allocation on the fly (this can be used in other places in the code to improve performance) see add temp field on boundary space to cache #584
  • new function for water_albedo_from_wind! in the FluxCalculator and an extended method for ClimaAtmos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍃 leaf Issue coupled to a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants