I played around with this a little this morning...we can't implement this without adding both ClimaTimesteppers and ODE.jl to the ClimaLSM main project dependencies. This is because, in the implicit model case, we have

  CTS.ClimaODEFunction(
            T_exp! = exp_tendency!,
            T_imp! = ODE.ODEFunction(imp_tendency!; jac_kwargs...),
            dss! = ClimaLSM.dss!,
        ),

I dont mind adding CTS, but ODE.jl really slows down the precompilation time.

What do you think? Maybe we can wait on this and for now just add clear documentation that dss! must be used (and why)?

For now, I will make a PR that adds dss! to all simulations/tutorials and notes that we need to use it.
#321

Charlie recommended that we could avoid adding ODE.jl by using SciMLBase.jl instead. SciMLBase implements ODEFunction, ODEProblem, and solve, which is what we're currently using ODE for. I like this as a solution to avoid longer precompilation due to ODE.jl, in src/ but also in all of our other directories. Here is a PR in ClimaAtmos.jl attempting to make this change there: CliMA/ClimaAtmos.jl#2074. They ran into some trouble because they're using some functions that are defined in ODE.jl, but we don't have this problem, so it should be a pretty straightforward change for us.

As a note: I noticed that since we now have DiffEqCallbacks in the top-level project, ODE.jl appears in the Manifest under [deps.DiffEqCallbacks.weakdeps]. I thought this might already affect the precompilation time even though ODE.jl is not a direct dependency, but Charlie explained that a weakdep will not get loaded automatically and therefore not affect precompilation unless it's explicitly loaded (just wanted to document that here).

Charlie just opened a PR making this fix: #323

awesome! Let's do something like...merge your safe test PR #322 and then we merge #323 , and then go back to the dss PR I had 🔢 #321 - we can either rework it to add in the wrapper function or else close it and start fresh.

I like this as a solution to avoid longer precompilation due to ODE.jl, in src/ but also in all of our other directories.

good idea!