New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`construct_atmos_ts` allocates at every step #588

Closed

Tracked by

Sbozzolo opened this issue Apr 23, 2024 · 0 comments · Fixed by #589

Closed

Tracked by

`construct_atmos_ts` allocates at every step #588

Sbozzolo opened this issue Apr 23, 2024 · 0 comments · Fixed by #589

Assignees

Milestone

O2.3.5 Global run...

Member

Sbozzolo commented Apr 23, 2024 •

edited

This is probably in

function construct_atmos_ts(
    atmos::PrescribedAtmosphere{FT},
    p,
    thermo_params,
) where {FT}
    P = p.drivers.P
    T = p.drivers.T
    q = p.drivers.q
    ts_in = Thermodynamics.PhaseEquil_pTq.(thermo_params, P, T, q)
    return ts_in
end

This was referenced Apr 23, 2024

Identify low-hanging fruit in performance #586

Open

Preallocate thermal state #589

Merged

Sbozzolo added this to the O2.3.5 Global run on GPU milestone

Sbozzolo self-assigned this

Sbozzolo closed this as completed in #589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment