Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create two new advection schemes: UpwindBiasedFirstOrder and CenterSixthOrder #1320

Closed
francispoulin opened this issue Jan 27, 2021 · 3 comments

Comments

@francispoulin
Copy link
Collaborator

Given that the framework is set up already it should be easy to create each of these and add them to our collection.

The only reason I can see for not creating them is that the number of advection schemes might be large. Is this a concern?

@ali-ramadhan
Copy link
Member

I'm not against a proliferation of advection schemes.

We should probably not merge new advection schemes without a convergence test though?

@francispoulin
Copy link
Collaborator Author

Thanks @ali-ramadhan and I agree completely.

When I was working on the validation schemes I did test these schemes outside of Oceananigans and they did produce the correct slopes of -1 and -6. Sixth order accuracy could actually be attractive for some applications. Getting first order from upwinding may not sound llike much but it does ensure positivity, which might also be helpful for some cases where you want to ensure tracer concentrations are non-negative.

@glwagner
Copy link
Member

We have these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants