-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*Enhance* simulation Callback
and model StateModifier
utilities
#1895
Comments
1 similar comment
Probably related: I saw the new In one of my usages I was hacking a progress function https://github.com/aramirezreyes/RamirezReyes_ShallowWaterInFPlane/blob/c1971c0cb3fc99fbb2dbf3303a8fd60b17a59d5a/scripts/run_oceananigans_example_cpu.jl#L101 to update some arrays on a parameterization. Unfortunately, this depended on the Is there a way to recover this ability? (there are other ways of getting it to work but having it in the design would be nice). |
I opened a new issue for parameterized Callbacks --- check out #2127 |
We got this now |
Ah wow, that is epic.
I think what's implemented here is more or less analogous to
DiscreteCallback
.Reading over the features there makes me realize that we probably want to "align" the time-step (somehow, similar to the root finding feature that's provided for DiffEq) for callbacks. We align time-steps for output, but not for callbacks (yet). That would be nice to add.
I think we could also add an analog of the "continuous callback" --- to the models, not the simulations --- that's executed during
update_state!
, and therefore can be thought of as a function that "continuously" (eg valid at every moment in time) modifies the state of the model. PerhapsStateModifier
or something like that? These objects would not have a schedule since they'd always be executed.Initialization and finalization might be good wishlist features too for both.
Originally posted by @glwagner in #1894 (comment)
The text was updated successfully, but these errors were encountered: