Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More comprehensive testing for immersed boundaries #1937

Closed
glwagner opened this issue Aug 17, 2021 · 1 comment
Closed

More comprehensive testing for immersed boundaries #1937

glwagner opened this issue Aug 17, 2021 · 1 comment
Labels
testing 🧪 Tests get priority in case of emergency evacuation

Comments

@glwagner
Copy link
Member

PRs #1935 and #1936 fix bugs associated with ImmersedBoundaryGrid: the first is a functionality bug that needs a detailed functionality test to catch (for example, testing that budgets are correct with immersed boundaries); the second fixes a more trivial issue with dispatch.

We have a small number of immersed boundary tests; however we need a more comprehensive suite of tests to ensure that immersed boundaries are compatible with various closures and advection schemes.

I think we should use the hydrostatic model for these tests for the time being, because immersed boundaries with non hydrostatic models are still experimental and under development.

cc @whitleyv @jm-c

@glwagner glwagner added the testing 🧪 Tests get priority in case of emergency evacuation label Aug 17, 2021
@glwagner glwagner changed the title More comprehensive unit testing for immersed boundaries More comprehensive testing for immersed boundaries Aug 17, 2021
@glwagner
Copy link
Member Author

I'm closing this issue because I'm judging that it's not of current, timely relevance to Oceananigans development. If you would like to make it a higher priority or if you think the issue was closed in error please feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing 🧪 Tests get priority in case of emergency evacuation
Projects
None yet
Development

No branches or pull requests

1 participant