Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we really need AbstractCPUArchitecture? #2072

Closed
simone-silvestri opened this issue Nov 19, 2021 · 6 comments
Closed

Do we really need AbstractCPUArchitecture? #2072

simone-silvestri opened this issue Nov 19, 2021 · 6 comments
Labels
cleanup 🧹 Paying off technical debt

Comments

@simone-silvestri
Copy link
Collaborator

If we are thinking to unify MultiCPU and MultiGPU in a more general MultiArch which will contain the child_architecture information, AbstractCPUArchitecture and AbstractGPUArchitecture become obsolete...
@glwagner
Copy link
Member

Agree! I think this is a duplicate of #2020 ?

@simone-silvestri
Copy link
Collaborator Author

Kind of :). I was thinking to just remove the AbstractCPU and AbstractGPU acrhitecture types

@glwagner
Copy link
Member

Ah for sure. Yeah, it doesn't seem like it'd have any impact on the code.

@glwagner glwagner added the cleanup 🧹 Paying off technical debt label Nov 30, 2021
@glwagner
Copy link
Member

@simone-silvestri we don't have this anymore right?

@simone-silvestri
Copy link
Collaborator Author

No, just AbstractMultiArchitecture (which we might want to delete) and AbstractArchitecture

@glwagner
Copy link
Member

Then I'm closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup 🧹 Paying off technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glwagner @simone-silvestri