Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking scripts for immersed boundaries and immersed boundary conditions #2452

Closed
glwagner opened this issue Apr 21, 2022 · 2 comments
Closed
Labels
immersed boundaries ⛰️ Less Ocean, more anigans performance 🏍️ So we can get the wrong answer even faster

Comments

@glwagner
Copy link
Member

We need to benchmark various flavors of ImmersedBoundaryGrid including

  • GridFittedBoundary for immersed boundaries that are both function-based (computed on the fly) and array-based (precomputed)
  • GridFittedBottom for the same (I think for this case, precomputation is always wise. That's not the case for GridFittedBoundary though. The benchmarks will hopefully show this.)
  • Various immersed boundary conditions implemented in Support boundary conditions on immersed boundaries #2437

These should be implemented for both NonhydrostaticModel and HydrostaticFreeSurfaceModel.

@glwagner glwagner added performance 🏍️ So we can get the wrong answer even faster immersed boundaries ⛰️ Less Ocean, more anigans labels Apr 21, 2022
@francispoulin
Copy link
Collaborator

If we are doing this, could we also try doing immersed coastal boundaries for ShallowWaterModel? It shouldn't be any harder and would be nice to make sure everything works there as well.

@glwagner
Copy link
Member Author

I'm closing this issue because I'm judging that it's not of current, timely relevance to Oceananigans development. If you would like to make it a higher priority or if you think the issue was closed in error please feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
immersed boundaries ⛰️ Less Ocean, more anigans performance 🏍️ So we can get the wrong answer even faster
Projects
None yet
Development

No branches or pull requests

2 participants