Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for OffsetArrays-Field broadcasts #2501

Closed
simone-silvestri opened this issue Apr 29, 2022 · 2 comments
Closed

Tests for OffsetArrays-Field broadcasts #2501

simone-silvestri opened this issue Apr 29, 2022 · 2 comments

Comments

@simone-silvestri
Copy link
Collaborator

with @glwagner we introduced broadcasts across fields and OffsetArrays that include halos, so that

field1 = CenterField(grid)
field2 = CenterField(grid)

set!(field1, (x, y, z) -> x)

data = field1.data

field2 .= data

or alternatively

set!(field2, data)

will set not only the interior of the field, but also the halos, without the need of fill_halo_regions!

We need tests to make sure this feature does not break somewhere...

@francispoulin
Copy link
Collaborator

Very nice!

@glwagner
Copy link
Member

I'm closing this issue because I'm judging that it's not of current, timely relevance to Oceananigans development. If you would like to make it a higher priority or if you think the issue was closed in error please feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants