Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Near global quarter degree validation experiment is broken #2690

Closed
glwagner opened this issue Aug 3, 2022 · 2 comments · Fixed by #3012
Closed

Near global quarter degree validation experiment is broken #2690

glwagner opened this issue Aug 3, 2022 · 2 comments · Fixed by #3012

Comments

@glwagner
Copy link
Member

glwagner commented Aug 3, 2022

At least, this is not the current syntax for discrete diffusion function:

@inline νhb(i, j, k, grid, lx, ly, lz) = (1 / (1 / Δx(i, j, k, grid, lx, ly, lz)^2 + 1 / Δy(i, j, k, grid, lx, ly, lz)^2 ))^2 / 5days

There are also some formatting irregularities here:

@inline function getdiffusivity(dd::DiscreteDiffusionFunction{LX, LY, LZ},
i, j, k, grid, location, clock, fields) where {LX, LY, LZ}
from = (LX(), LY(), LZ())
return ℑxyz(i, j, k, grid, from, location, dd.func, clock, fields, dd.parameters)
end
@inline function getdiffusivity(dd::UnparameterizedDDF{LX, LY, LZ},
i, j, k, grid, location, clock, fields) where {LX, LY, LZ}
from = (LX(), LY(), LZ())
return ℑxyz(i, j, k, grid, from, location, dd.func, clock, fields)
end

@glwagner
Copy link
Member Author

glwagner commented Aug 3, 2022

Also if we are following syntax for Forcing and BoundaryConditions, we may want to use the ordering i, j, k, grid, clock, fields, location, which preserves the logic:

  1. position (i, j, k, grid)
  2. time (clock, iteration, time)
  3. fields
  4. "everything else"

@glwagner
Copy link
Member Author

I think we should just remove these validation experiments since we have ClimaOcean now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant