Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate over a node list instead of using nested loops. #61

Closed
ali-ramadhan opened this issue Feb 20, 2019 · 2 comments
Closed

Iterate over a node list instead of using nested loops. #61

ali-ramadhan opened this issue Feb 20, 2019 · 2 comments
Labels
cleanup 🧹 Paying off technical debt feature 🌟 Something new and shiny

Comments

@ali-ramadhan
Copy link
Member

ali-ramadhan commented Feb 20, 2019

@peterahrens suggested iterating over a list of nodes, e.g. using a CartesianIndices iterator instead of looping over all the indices with a nested for loop.

However, according to @vchuravy this may not work with GPUifyLoops.jl right now so this issue has no associated milestone. Actually, see: vchuravy/GPUifyLoops.jl#18 (comment)

This will actually be really great once we move to other non-Cartesian grids as we can just use a different iterator (CubedSphereIndices?) and not have to modify the time stepping code.

See: Multidimensional algorithms and iteration

@ali-ramadhan ali-ramadhan added feature 🌟 Something new and shiny cleanup 🧹 Paying off technical debt labels Feb 20, 2019
@glwagner
Copy link
Member

@ali-ramadhan
Copy link
Member Author

I think we'll end up doing this when we switch to KernelAbstractions.jl anyways so I'm closing this issue as it has become stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Paying off technical debt feature 🌟 Something new and shiny
Projects
None yet
Development

No branches or pull requests

2 participants