Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rescaling Normal(mu, sig) by 1/abs(mu) is undefined when mu=0 #173

Closed
glwagner opened this issue Feb 5, 2022 · 1 comment
Closed

Rescaling Normal(mu, sig) by 1/abs(mu) is undefined when mu=0 #173

glwagner opened this issue Feb 5, 2022 · 1 comment

Comments

@glwagner
Copy link
Member

glwagner commented Feb 5, 2022 •
edited

We rescale Normal by it's mean value (ostensibly producing distributions with a mean of 1):

https://github.com/CliMA/OceanTurbulenceParameterEstimation.jl/blob/b1351f5cbe5e7159d5107b6754f75442b08e908d/src/Parameters.jl#L165

but this is undefined for distributions with 0 mean.

What we are trying to achieve with this rescaling? Does it make more sense to divide by standard deviation?

@adelinehillier let me know what you think.
@adelinehillier
Copy link
Collaborator

This was fixed at some point!

ParameterEstimocean.jl/src/Parameters.jl

Line 182 in a5ecff2

unconstrained_prior(Π::Normal) = Normal(0, 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glwagner @adelinehillier