Updated Oxla results #181
Merged
Updated Oxla results #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@tinybit PTAL. |
melvynator
approved these changes
May 28, 2024
There was a problem hiding this comment.
@adam-szymanski Thank you for your contribution.
I was able to reproduced your test.
Means Comparison:
Your submission 1:
Column 1: 1.929
Column 2: 1.244
Column 3: 1.249
My replication:
Column 1: 2.072
Column 2: 1.676
Column 3: 1.363
The script worked well, the only hiccup I faced was around the download of the data that for some reason I was not able to attached to the docker container probably and I had to download it directly from the container.
But I think we should be good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have run newest version of Oxla (1.20) and have created an index that exactly matches ordering of table definition in Clickhouse.