Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play.clickhouse.tech displays Int64 incorrectly 9223372033328794000 instead of 9223372033328793741 #10824

Closed
den-crane opened this issue May 11, 2020 · 10 comments · Fixed by #35452
Assignees

Comments

@den-crane
Copy link
Contributor

den-crane commented May 11, 2020


SELECT '- '||toString(max(WatchID))||' -', max(WatchID), toString(max(WatchID)) 
FROM hits_100m_obfuscated
where WatchID = 9223372033328793741


- 9223372033328793741 - | 9223372033328794000   | 9223372033328794000

https://stackoverflow.com/questions/61739114/condition-on-uint64-field-in-where-clause-in-clickhouse/61740693#61740693

select toUInt64(-1) x, toString(x) y, '['||y||']'
18446744073709552000 | 18446744073709552000 | [18446744073709551615]
JS issue

> d=18446744073709551615
18446744073709552000
> d='18446744073709551615'
'18446744073709551615'
@den-crane den-crane added the bug Confirmed user-visible misbehaviour in official release label May 11, 2020
@alexey-milovidov alexey-milovidov added the comp-documentation Documentation label May 11, 2020
@filimonov
Copy link
Contributor

A bit too long opened for crit. Any movements here?

@alexey-milovidov
Copy link
Member

@qoega ?

@alexey-milovidov
Copy link
Member

alexey-milovidov commented Oct 21, 2020

In version 20.11 we have completely new web UI:
http://localhost:8123/play
that does not have such an embarrassing issue.

It's still in question, if the Playground even theoretically fixable, see https://github.com/ClickHouse/clickhouse-playground/issues
If it's not supported for half a year, maybe it's better to just throw it off.

@alexey-milovidov
Copy link
Member

We will close the old Playground unless the issues will be fixed:
https://github.com/ClickHouse/clickhouse-playground/issues

@alexey-milovidov
Copy link
Member

There are more complaints about playground from external users:
https://habr.com/en/company/tensor/blog/536696/#comment_22528138

@alexey-milovidov
Copy link
Member

Replacing it with https://gh-api.clickhouse.tech/play?user=play looks viable, only need to add "Powered by Yandex.Cloud" link.

@sundy-li
Copy link
Contributor

sundy-li commented Jan 12, 2021

Hello, another issue about play web is to support MetaKey + Enter hotkey to execute query (it's common used in macos).

But it's not javascript standard to have that. Can we have jquery.min.js dependency? (The origin style may not be happy)

Refer:
https://github.com/VKCOM/lighthouse/blob/d701335c25cd1bb9b5155711190bad8ab852c2ce/app.js#L60-L65

@alexey-milovidov
Copy link
Member

JQuery is a bit too large for this small feature (and also it's old-fashioned).
Maybe just add metaKey here?: https://github.com/ClickHouse/ClickHouse/blob/master/programs/server/play.html#L430

@sundy-li
Copy link
Contributor

sundy-li commented Jan 12, 2021

@alexey-milovidov
Copy link
Member

Maybe just extract the snippet to detect meta key from jQuery?

@alexey-milovidov alexey-milovidov added bug on website and removed bug Confirmed user-visible misbehaviour in official release labels Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants