Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not lose stderr/stdout from clickhouse-odbc-bridge #13077

Open
qoega opened this issue Jul 29, 2020 · 1 comment
Open

Do not lose stderr/stdout from clickhouse-odbc-bridge #13077

qoega opened this issue Jul 29, 2020 · 1 comment

Comments

@qoega
Copy link
Member

qoega commented Jul 29, 2020

Describe the issue
We store only logs for odbc_bridge

Here we do not forward stderr/out somewhere.

return ShellCommand::executeDirect(path.toString(), cmd_args, true);

It can lead to hang

@qoega
Copy link
Member Author

qoega commented Mar 9, 2023

I should check that it works as expected and we can close

if (config.has("logger." + configPrefix() + "_log"))
{
cmd_args.push_back("--log-path");
cmd_args.push_back(config.getString("logger." + configPrefix() + "_log"));
}
if (config.has("logger." + configPrefix() + "_errlog"))
{
cmd_args.push_back("--err-log-path");
cmd_args.push_back(config.getString("logger." + configPrefix() + "_errlog"));
}
if (config.has("logger." + configPrefix() + "_stdout"))
{
cmd_args.push_back("--stdout-path");
cmd_args.push_back(config.getString("logger." + configPrefix() + "_stdout"));
}
if (config.has("logger." + configPrefix() + "_stderr"))
{
cmd_args.push_back("--stderr-path");
cmd_args.push_back(config.getString("logger." + configPrefix() + "_stderr"));
}
if (config.has("logger." + configPrefix() + "_level"))
{
cmd_args.push_back("--log-level");
cmd_args.push_back(config.getString("logger." + configPrefix() + "_level"));
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant