You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If someone tries to rebuild clickhouse/style-test docker image from Dockerfile https://github.com/ClickHouse/ClickHouse/blob/master/docker/test/style/Dockerfile and use it to perform stylecheck,
he or she would face a number of errors (mostly from spellchecker).
The reason: versions of python modules are not specified and the customly built image would have more recent versions with different behavior.
It is not a big deal because the docker image keeps its state, but I think the behavior can be improved.
I doubt that the issue is unique, although stylecheck machinery is very dependable on how old python modules are used.
I can
(1) make PR that explicitly sets versions we currently have in the image or (2) make PR that explicitly sets versions for the most latest versions of modules and fix errors found in master.
The text was updated successfully, but these errors were encountered:
If someone tries to rebuild clickhouse/style-test docker image from Dockerfile https://github.com/ClickHouse/ClickHouse/blob/master/docker/test/style/Dockerfile and use it to perform stylecheck,
he or she would face a number of errors (mostly from spellchecker).
The reason: versions of python modules are not specified and the customly built image would have more recent versions with different behavior.
It is not a big deal because the docker image keeps its state, but I think the behavior can be improved.
I doubt that the issue is unique, although stylecheck machinery is very dependable on how old python modules are used.
I can
(1) make PR that explicitly sets versions we currently have in the image or (2) make PR that explicitly sets versions for the most latest versions of modules and fix errors found in master.
The text was updated successfully, but these errors were encountered: