Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style check docker image is not reproducible #40666

Open
ilejn opened this issue Aug 26, 2022 · 1 comment
Open

style check docker image is not reproducible #40666

ilejn opened this issue Aug 26, 2022 · 1 comment
Labels

Comments

@ilejn
Copy link
Contributor

ilejn commented Aug 26, 2022

If someone tries to rebuild clickhouse/style-test docker image from Dockerfile https://github.com/ClickHouse/ClickHouse/blob/master/docker/test/style/Dockerfile and use it to perform stylecheck,
he or she would face a number of errors (mostly from spellchecker).
The reason: versions of python modules are not specified and the customly built image would have more recent versions with different behavior.

It is not a big deal because the docker image keeps its state, but I think the behavior can be improved.
I doubt that the issue is unique, although stylecheck machinery is very dependable on how old python modules are used.

I can
(1) make PR that explicitly sets versions we currently have in the image or (2) make PR that explicitly sets versions for the most latest versions of modules and fix errors found in master.

@ilejn ilejn added the feature label Aug 26, 2022
@alexey-milovidov
Copy link
Member

Thank you!

Let's do

(2) make PR that explicitly sets versions for the most latest versions of modules and fix errors found in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants