-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segfault in ConnectionEstablisher
/ProfileEvents
#51313
Comments
I am not sure that it was introduced in #50034, don't see any connection to the OpenTelemetry. And actually, it's really strange. Seems like we got segfault trying to read data from ClickHouse/src/Common/CurrentThread.cpp Line 50 in 7028f9e
But how can it be invalid pointer. It points to another field of the struct: ClickHouse/src/Common/ThreadStatus.h Lines 162 to 165 in 7028f9e
Only place where we can change this pointer is using According to logs, we started fibers in one thread and finish in another thread (cancellation thread). The segfault happens during query cancellation while we are trying to increment profile events. But I don't see any problems here, we just use thread local ThreadStatus from cancellation thread that was created outside of fibers. And again, I spent a lot of time trying to reproduce with different stress testing and nothing happend... |
Sorry, I just noticed that this line
Also the |
Yes. I also thought about it. I even can imagine how it's possible. We update |
Let's see if we can catch invalid |
looks similar issue: https://s3.amazonaws.com/clickhouse-test-reports/50625/dcda3576d25b46e8bfbacb2e2a447952de350bc0/stateless_tests__tsan__[3_5]/stderr.log
|
Didn't see this failure after #52533, let's close |
Got this today:
Sadly, but I don't have query logs for that time already (sigh) |
Need logs of thread |
Sadly, but I don't have them
It is not, the 24.2.2 contains the backport of this patch. |
Maybe worth enabling |
https://s3.amazonaws.com/clickhouse-test-reports/51135/220520c516bea15399396b5f82aa3ab2d6cd9ca3/upgrade_check__debug_.html
Introduced in #50034
The text was updated successfully, but these errors were encountered: