Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets aren't uploaded to a release because of failing API #52847

Closed
shahargv opened this issue Aug 1, 2023 · 7 comments
Closed

Assets aren't uploaded to a release because of failing API #52847

shahargv opened this issue Aug 1, 2023 · 7 comments
Assignees
Labels

Comments

@shahargv
Copy link

shahargv commented Aug 1, 2023

Hey,

Version 23.7 has only 8 assets in the GitHub releases page (unlike 52 in previous releases). Among the missing files there's no RPM files.

I'd appreciate it if you can also add the missing files, so we could enjoy this new version.

Thanks!

@shahargv shahargv added the potential bug To be reviewed by developers and confirmed/rejected. label Aug 1, 2023
@alexey-milovidov alexey-milovidov added build and removed potential bug To be reviewed by developers and confirmed/rejected. labels Aug 1, 2023
@Felixoid Felixoid self-assigned this Aug 2, 2023
@Felixoid
Copy link
Member

Felixoid commented Aug 2, 2023

Hello. The assets' upload failed due to the API 500

I'll adjust the code, it obviously should have:

  1. retries
  2. check for the message key
  3. raise exception in else

The assets are uploaded manually, but it still misses macos' binaries including macos

@Felixoid
Copy link
Member

Felixoid commented Aug 2, 2023

BTW, for RPM packages consider using https://packages.clickhouse.com/rpm/stable/ repository, all the files are there

@alexey-milovidov
Copy link
Member

We will have the next patch release today or tomorrow, and I hope the files will be uploaded successfully this time.

@Felixoid Felixoid reopened this Aug 2, 2023
@Felixoid
Copy link
Member

Felixoid commented Aug 2, 2023

Please, leave it for me. I am fixing the issue in both repos and would like to have PR linked here

@alexey-milovidov
Copy link
Member

We released the patch release yesterday, so the issue should be resolved.

@alexey-milovidov alexey-milovidov changed the title Missing RPM files for v23.7 (Resolved) Missing RPM files for v23.7 Aug 4, 2023
@Felixoid Felixoid changed the title (Resolved) Missing RPM files for v23.7 Assets aren't uploaded to a release because of failing API Aug 4, 2023
@Felixoid
Copy link
Member

I've deployed the fixed code, so now waiting for any new version being released

@Felixoid
Copy link
Member

Fixed in ClickHouse/clickhouse-repos-manager#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants