New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output valid JSON/XML on exception during HTTP query execution #52853
Output valid JSON/XML on exception during HTTP query execution #52853
Conversation
This is an automated comment for commit e163670 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
@SmitaRKulkarni sorry for long responses, can you please continue reviewing this PR? I abondoned it for some time but now I am ready to finish it |
@SmitaRKulkarni kind ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…a6b555319efc53348b69457966189 Cherry pick #52853 to 23.8: Output valid JSON/XML on exception during HTTP query execution
Backport #52853 to 23.8: Output valid JSON/XML on exception during HTTP query execution
} | ||
|
||
void resetFormatterImpl() override | ||
{ | ||
validating_ostr = std::make_unique<WriteBufferValidUTF8>(this->out); | ||
ostr = validating_ostr.get(); | ||
LOG_DEBUG(&Poco::Logger::get("RowOutputFormatWithExceptionHandlerAdaptor"), "resetFormatterImpl"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some kind of debugging had been left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's delete it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Output valid JSON/XML on excetpion during HTTP query execution. Add setting
http_write_exception_in_output_format
to enable/disable this behaviour (enabled by default).Documentation entry for user-facing changes
Previous behaviour:
New behaviour: