Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for async_insert for prepared blocks sent over the native protocol. #54381

Closed
alexey-milovidov opened this issue Sep 7, 2023 · 2 comments · Fixed by #54730
Closed
Assignees
Labels

Comments

@alexey-milovidov
Copy link
Member

Use case

Many clients are concurrently sending data using Distributed tables.

Describe the solution you'd like

Deserialize blocks as usual, put them in the queue for async inserts, and squash them.
This is slightly different from how async inserts operate, but in fact, even simpler (no parsing).

@CurtizJ
Copy link
Member

CurtizJ commented Sep 16, 2023

Do we want to support INSERT SELECT?

@alexey-milovidov
Copy link
Member Author

Do we want to support INSERT SELECT?

It's unnecessary - if it has any additional complexity, it is to skip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants