Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade test fails due to removal of is_deleted feature #58026

Closed
Algunenano opened this issue Dec 19, 2023 · 2 comments · Fixed by #58267 or #58316
Closed

Upgrade test fails due to removal of is_deleted feature #58026

Algunenano opened this issue Dec 19, 2023 · 2 comments · Fixed by #58267 or #58316
Assignees
Labels
testing Special issue with list of bugs found by CI

Comments

@Algunenano
Copy link
Member

Example run: https://s3.amazonaws.com/clickhouse-test-reports/57235/52db759c92744bad1a715fb7dbf7ec665ba36452/upgrade_check__tsan_.html

When starting up you'll get this:

2023.12.18 15:03:32.310765 [ 1056336 ] {} <Error> Application: Caught exception while loading metadata: Code: 695. DB::Exception: Load job 'load table test_9.testCleanupR1' failed: Code: 36. DB::Exception: Wrong number of engine arguments.: Cannot attach table `test_9`.`testCleanupR1` from metadata file /var/lib/clickhouse/store/b1f/b1fea9ec-714f-42d2-b142-fc481cf10d83/testCleanupR1.sql from query ATTACH TABLE test_9.testCleanupR1 UUID 'a071beb3-4e13-4e22-8f6e-c29ae9714aae' (`uid` String, `version` UInt32, `is_deleted` UInt8) ENGINE = ReplicatedReplacingMergeTree('/clickhouse/test_9/tables/test_cleanup/', 'r1', version, is_deleted) ORDER BY uid SETTINGS enable_vertical_merge_algorithm = 1, vertical_merge_algorithm_min_rows_to_activate = 0, vertical_merge_algorithm_min_columns_to_activate = 0, min_rows_for_wide_part = 0, min_bytes_for_wide_part = 0, index_granularity = 28733, ratio_of_defaults_for_sparse_serialization = 0., replace_long_file_name_to_hash = 1, max_file_name_length = 57, merge_max_block_size = 17933, prefer_fetch_merged_part_size_threshold = 10737418240, min_merge_bytes_to_use_direct_io = 10737418240, index_granularity_bytes = 19047569, allow_vertical_merges_from_compact_to_wide_parts = 1, marks_compress_block_size = 48010, primary_key_compress_block_size = 17627. (BAD_ARGUMENTS), Stack trace (when copying this message, always include the lines below):

This is a breaking change (#57930) so it's expected that it will break things, but there isn't a simple way to fix it. I'm not sure if we should just ignore these errors in CI, have a way to skip loading these tables or autofix them by ignoring the last parameter via setting (which might be troublesome in the future). Thoughs @alexey-milovidov?

@Algunenano
Copy link
Member Author

Addressed in #58104

@Algunenano
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Special issue with list of bugs found by CI
Projects
None yet
2 participants