Query parameter support for engine identifier

[jkaflik]

Describe the unexpected behaviour

Currently, it's not possible to pass an table engine name as a query parameter:

  CREATE TABLE IF NOT EXISTS {table:Identifier} (
  		key String
  	, value String
  	, expiration DateTime
  ) ENGINE={engine:Identifier}

It's not correctly handled in the parser and results in Unknown table engine . (UNKNOWN_STORAGE) error. (empty engine name)

How to reproduce

• 24.2.1.174
• originally raised in Create table failing when engine parameter is present in query clickhouse-go#1238

Expected behavior

ENGINE={engine:Identifier} is substituted before the table engine parse.

[alexey-milovidov]

I think it is not worth it.

[mirusky]

More than 1 developer requesting it, maybe you need to reconsider.

Since the current solution is to use "string replacement", it is opening the door for SQL Injection.

I think using engine identifier could save us since it can be sanitized