Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added minimum version of dep tzlocal #361

Closed
wants to merge 1 commit into from

Conversation

drew-talon
Copy link
Contributor

@drew-talon drew-talon commented Jun 14, 2024

Summary

Fix for: #360
Not all versions of tzlocal support get_localzone_name()

clickhouse_connect/driver/tzutil.py

local_name = tzlocal.get_localzone_name()

local_name = tzlocal.get_localzone_name()

This function is only available in tzlocal 4.0.0 and up.
See:
https://github.com/regebro/tzlocal/blob/master/CHANGES.txt

4.0b2 (2021-09-26)

  • Big refactor; Implemented get_localzone_name() functions.

  • Adding a Windows OS environment variable 'TZ' will allow an override for
    setting the timezone (also see 4.0b3).

Checklist

  • A human-readable description of the changes was provided to include in CHANGELOG

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


drew-talon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@drew-talon drew-talon marked this pull request as draft June 14, 2024 15:35
@drew-talon drew-talon closed this Jun 14, 2024
@drew-talon drew-talon deleted the tzlocal-min-version branch June 14, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants