Add ZSTD compression #367
Merged
Add ZSTD compression #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Enmk Could you please trigger CI for this? |
Enmk
reviewed
Mar 7, 2024
| case static_cast<uint8_t>(CompressionMethodByte::NONE): { | ||
|
|
||
| throw CompressionError("compression method not defined" + std::to_string((method))); | ||
| } |
There was a problem hiding this comment.
please handle invalid\unsupported compression methods too:
Suggested change
| } | |
| } | |
| default: | |
| throw CompressionError("Unknown or unsupported compression method " + std::to_string((method))); |
Enmk
requested changes
Mar 12, 2024
clickhouse/base/compressed.h
Outdated
| }; | ||
|
|
||
| // see DB::CompressionMethodByte from src/Compression/CompressionInfo.h of ClickHouse project | ||
| enum class CompressionMethodByte : uint8_t { |
There was a problem hiding this comment.
Is that a part of the public API that users should know about? If not, please move away from the headers to the cpp.
clickhouse/client.h
Outdated
| @@ -3,6 +3,8 @@ | |||
| #include "query.h" | |||
| #include "exceptions.h" | |||
|
|
|||
| #include "base/compressed.h" | |||
There was a problem hiding this comment.
IMO this is not the best decision: clients are not expected to rely on stuff in base, at least explicitly. I think it is best to move the CompressionMethod declaration back to client.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve #35