-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify PrivateLink Setup #1866
base: main
Are you sure you want to change the base?
Conversation
This is an automated comment for commit 9b9cbae with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's update GCP PSC doc using the same notes?
@@ -17,7 +17,7 @@ AWS PrivateLink is only available in ClickHouse Cloud Production services. Devel | |||
Before you get started you will need: | |||
|
|||
1. An AWS account. | |||
1. An API key with the necessary permissions to create and manage private links. | |||
1. A [ClickHouse Cloud API key](https://clickhouse.com/docs/en/cloud/manage/openapi) with the necessary permissions to create and manage private links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK we have only 2 roles(atm): developer and admin, shall we mention explicitly to create key w/ admin access?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me, @konsta-danyliuk , what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natalyjazzviolin , yep, this seems more straightforward.
@tsolodov, If the Dev key type doesn't have sufficient permissions for Private Links set up, we should include the key type in the doc.
This adds clarification for a smoother PrivateLink setup process. So far this:
privateDnsHostname
is a placeholder.