fix-docs/en/tutorial.md_4.-Create-a-Dictionary/7.-'dropoff'-to-'pickup' #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
SELECT
count(1) AS total,
dictGetOrDefault('taxi_zone_dictionary','Borough', toUInt64(pickup_nyct2010_gid), 'Unknown') AS borough_name
FROM trips
WHERE dropoff_nyct2010_gid = 132 OR dropoff_nyct2010_gid = 138
GROUP BY borough_name
ORDER BY total DESC
```
```dictGetOrDefault('taxi_zone_dictionary','Borough', toUInt64(pickup_nyct2010_gid), 'Unknown')``` get the borough of the 'pickup_nyct2010_gid' so this is supposed to show 'Unknown' when 'pickup_nyct2010_gid' is unknown, meaning when the "pickup" Borough is 'Unknown' and not the "dropoff" is 'Unknown', as we know and precisely select the "dropoff" in this query to be JFK or LaGuardia,
But the current documentation state ```The result looks like the following, and notice there are quite a few trips where the *dropoff* neighborhood is unknown``` instead ```The result looks like the following, and notice there are quite a few trips where the *pickup* neighborhood is unknown```.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
From this query, in the
docs/en/tutorial.mdfile, at "4. Create a Dictionary" step 7, the current docs stateThe result looks like the following, and notice there are quite a few trips where the *dropoff* neighborhood is unknowninstead of, I think,The result looks like the following, and notice there are quite a few trips where the *pickup* neighborhood is unknown,As we already know the dropoff which are either
dropoff_nyct2010_gid = 132ordropoff_nyct2010_gid = 138and we're looking at the pickup locations for these two dropoff withdictGetOrDefault('taxi_zone_dictionary','Borough', toUInt64(pickup_nyct2010_gid), 'Unknown')which set to 'Unknown' the pickup Borough if the given pickup idpickup_nyct2010_gidisn't found in the dictionary.