Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support scan of custom types implementing sql.Scanner into array/tuple columns #1129

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Support scan of custom types implementing sql.Scanner into array/tuple columns #1129

merged 2 commits into from
Oct 26, 2023

Conversation

leodido
Copy link
Contributor

@leodido leodido commented Oct 23, 2023 •
edited

Summary

Fixes #1128

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@leodido
fix(lib/column): support scan of custom types implementing sql.Scanner
0182671 
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido
test: test for issue 1128
6976c49 
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@jkaflik jkaflik self-requested a review October 24, 2023 06:23
jkaflik
jkaflik approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 💪

@jkaflik jkaflik merged commit 25571c8 into ClickHouse:main Oct 26, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaflik jkaflik jkaflik approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't scan an array of non-string custom types
2 participants
@leodido @jkaflik