Implementation ClickHousePreparedStatementImpl#getMetaData()
#238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIXME: without actual execution
This was referenced Oct 1, 2018
serebrserg
suggested changes
Oct 26, 2018
There was a problem hiding this comment.
We can get metadata without really executing full query by issuing query with limit 0. I think this should be more expected behavior than executing full query. However this needs some enhancement of parsing/modification of sql query (from first impression, it is enough to add limit 0 at the very end of select query)
|
The option with limit was implemented in #288 . Thanks for your effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I implement
ClickHousePreparedStatementImpl#getMetaData().This method needs to execute query if before execution query for getting ResultSet via
getResultSet().