#307 provide a way to build values for IN clause

[doom369]

Currently clickhouse jdbc driver doesn't provide any way to specify dynamic number of values for IN clause. For example,

List<Integer> list = Arrays.asList(1,2,3,4,5);
statement.setObject(1, list);

for where id in (?) will always build an array:

WHERE id IN ([1,2,3,4,5])

while result should be:

WHERE id IN (1,2,3,4,5)

Fixes #307.

This PR breaks back compatibility for those who uses setObject method with list. They need to use array instead of the list in order to preserve previous behaviour.

[Au6ojlut]

Well, there is one way to do so. You can convert list of objects for in clause to string like 1,2,3,4,5, then convert it to byte[] and setObject(index, byte[]).

Yeah, it looks awful but it works...

[doom369]

Yes, there are workarounds, however current clickhouse flow is not the same as in other drivers like postgres, so merging this PR will bring the same (and expected) flow as in other drivers. So migration from other solutions would be even simpler. The only problem - back compatibility. I think for major version this could be merged.

[den-crane]

note: For huge lists (>100.000) external data can be used https://clickhouse.yandex/docs/en/operations/table_engines/external_data/

[alex-krash]

Binding multiple values for IN() section is a common problem for any JDBC driver.
We are not going to merge this PR, moreover it brakes backward compatibility.

[doom369]

@alex-krash no problem.

For those who are interested in this and some other fixes/improvements we are gonna release own fork soon of this jdbc driver here https://github.com/blynkkk/clickhouse4j.

We already removed guava, jackson dependencies and working on making pluggable http client in order to make driver almost dependency free.

[himgang]

Well, there is one way to do so. You can convert list of objects for in clause to string like 1,2,3,4,5, then convert it to byte[] and setObject(index, byte[]).

Yeah, it looks awful but it works...

query = "select * from table where platform IN (?) limit 10;"

StringBuilder sb = new StringBuilder();
sb.append("1").append(",").append("2");
statement.setObject(3, sb.toString().getBytes());
@Au6ojlut
I am unable to get this to work for IN clause.
getting exception :
Caused by: java.lang.Throwable: Code: 62, e.displayText() = DB::Exception: Syntax error: failed at position 189: \x28\x31\x2C\x32\x29 group by url, domain ,groupedSections limit 1 FORMAT TabSeparatedWithNamesAndTypes;. Unrecognized token (version 19.17.6.36 (official build))

Please Suggest alternative or correct format, If I am making a mistake.