Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session id per connection #398

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Conversation

Enmk
Copy link
Collaborator

@Enmk Enmk commented Jul 8, 2022

Generating a random session_id, if none is specified in connection URI in config.

return param_kv.first == "session_id";
});

// DO not overwrite user-set session_id, just in case...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Collaborator

@filimonov filimonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@filimonov
Copy link
Collaborator

Ci/cd don't work properly - windows & Macos build are not starting:

Invalid workflow file: .github/workflows/macOS.yml#L1
invalid `cron` attribute "0.0.*.*.1"

I've committed the fix in #399
and now Macos builds fails... :|

@filimonov
Copy link
Collaborator

Ci/cd don't work properly - windows & Macos build are not starting:

Invalid workflow file: .github/workflows/macOS.yml#L1
invalid `cron` attribute "0.0.*.*.1"

I've committed the fix in #399 and now Macos builds fails... :|

will try to fix it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants