Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Exporter to a separate library package #20

Merged
merged 2 commits into from
Jun 26, 2018

Conversation

mstrzele
Copy link
Contributor

It fixes #9.

@mstrzele mstrzele force-pushed the package branch 3 times, most recently from 0efadc9 to 28a93e2 Compare June 15, 2018 06:55
@codecov-io
Copy link

codecov-io commented Jun 15, 2018

Codecov Report

Merging #20 into master will decrease coverage by 49.22%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #20       +/-   ##
========================================
- Coverage   49.22%    0%   -49.23%     
========================================
  Files           1     1               
  Lines         258    22      -236     
========================================
- Hits          127     0      -127     
+ Misses        112    22       -90     
+ Partials       19     0       -19
Impacted Files Coverage Δ
clickhouse_exporter.go 0% <0%> (-49.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e6dc2b...a191ee2. Read the comment docs.

@f1yegor
Copy link
Contributor

f1yegor commented Jun 26, 2018

Thanks a lot for the contribution!

@f1yegor f1yegor merged commit 070f143 into ClickHouse:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider moving Exporter type to the library package
3 participants