Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace prometheus/log package with log #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hanyuancheung
Copy link

@hanyuancheung hanyuancheung commented Sep 9, 2022

Background:
There are some old issues, between package github.com/sirupsen/logrus and github.com/Sirupsen/logrus.
When I import the clickhouse_exporter package into my project, I met the problem with: case-insensitive import collision.

I've searched several infos, like golang/dep#1010
clickhouse_exporter seems import sirupsen package because of the past-out prometheus/log package, which is already renamed and archived. https://github.com/prometheus-junkyard/log

So, I think clickhouse_exporter should remove prometheus/log package instead of using log package.

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2022

CLA assistant check
All committers have signed the CLA.

@hanyuancheung
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants