Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disk metrics error #81

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix: disk metrics error #81

merged 1 commit into from
Jul 5, 2023

Conversation

fuxingZhang
Copy link
Contributor

@fuxingZhang fuxingZhang commented Jul 3, 2023

fix issue #80

clickhouse_free_space_in_gigabytes and clickhouse_total_space_in_gigabytes are removed.
Because they can be calculated by free_space_in_bytes and total_space_in_bytes.

Visit http://localhost:9116/metrics, you can see:

image

image

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

exporter/exporter.go Outdated Show resolved Hide resolved
exporter/exporter.go Outdated Show resolved Hide resolved
exporter/exporter.go Outdated Show resolved Hide resolved
@fuxingZhang
Copy link
Contributor Author

Thanks for the guidance, I have revised and resubmitted.

@fuxingZhang fuxingZhang requested a review from Slach July 5, 2023 00:58
@Slach Slach merged commit 5ae7040 into ClickHouse:master Jul 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants