Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: i18n for schedules #116

Closed
wants to merge 2 commits into from
Closed

feat: i18n for schedules #116

wants to merge 2 commits into from

Conversation

WolfgangAl
Copy link
Contributor

This adds i18n/l10n options for the following:

  • the schedule summaries shown in the event creation dialog (by overriding dayspan/Schedule.prototype.describe + describeRule + describeArray and dayspan/DaySpan.prototype.summary)
  • the pattern labels in the frequency dropdown
  • rank numbers (by overriding dayspan/Suffix.CACHE use)

with default values for English

@WolfgangAl
Copy link
Contributor Author

NB: there is some overlap between this PR and #112

@ClickerMonkey
Copy link
Owner

Thanks for the work here - but this adds the moment dependency back to dayspan-vuetify - while I'm working on removing it from dayspan! (so there should be no moment dependency soon, making this code not necessary).

This does create a great blueprint though on the code in dayspan which affects the localizations in dayspan-vuetify - so thank you for that!

@WolfgangAl
Copy link
Contributor Author

WolfgangAl commented Nov 21, 2018 via email

@ClickerMonkey
Copy link
Owner

I know it's been awhile, but I've been at work on this - I've added i18n support to dayspan and am working on removing the dependency of Moment. Hopefully sometime within the next week it'll be done and ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants