get_metadata refactor, tests passing

datafs/core/data_archive.py

@@ -114,8 +114,8 @@ def authority(self):
     def archive_path(self):
         return self._archive_path
 
-    @property
-    def metadata(self):
+
+    def get_metadata(self):
         return self.api.manager.get_metadata(self.archive_name)
 
 

datafs/datafs.py

@@ -187,7 +187,7 @@ def download(ctx, archive_name, filepath, version):
 @click.pass_context
 def metadata(ctx, archive_name):
     var = ctx.obj.api.get_archive(archive_name)
-    click.echo(pprint.pformat(var.metadata))
+    click.echo(pprint.pformat(var.get_metadata()))
 
 
 @cli.command()

examples/local.py

@@ -138,7 +138,7 @@
 
 .. code-block:: python
 
-    >>> print(var.metadata['description'])
+    >>> print(var.get_metadata()['description'])
     My test data archive
 
 Add a file to the archive

examples/s3.py

@@ -151,7 +151,7 @@
 
 .. code-block:: python
 
-    >>> print(var.metadata['description'])
+    >>> print(var.get_metadata()['description'])
     My test data archive
 
 Add a file to the archive

tests/test_cli.py

@@ -144,7 +144,7 @@ def test_cli_local(test_config):
     assert result.exit_code == 0
     assert "'description': 'My test data archive'" in result.output or "u'description': u'My test data archive'" in result.output
     #test the api side of the operation
-    assert u'My test data archive' in api2.archives[0].metadata.values()
+    assert u'My test data archive' in api2.archives[0].get_metadata().values()
 
 
 
@@ -176,7 +176,7 @@ def test_cli_local(test_config):
         assert data == 'Hoo Yah! Stay Stoked!'
 
     #lets check to make sure our metadata update also passed through
-    assert 'Surfers Journal' ==  api2.archives[0].metadata['source']
+    assert 'Surfers Journal' ==  api2.archives[0].get_metadata()['source']
 
 
     #test to assert metadata update

tests/test_datafs.py

@@ -166,7 +166,7 @@ def test_create_archive(self, api):
         api.create_archive(archive_name, metadata={'testval': 'my test value'})
         var = api.get_archive(archive_name)
 
-        testval = var.metadata['testval']
+        testval = var.get_metadata()['testval']
 
         with pytest.raises(KeyError) as excinfo:
             api.create_archive(archive_name)
@@ -180,12 +180,12 @@ def test_create_archive(self, api):
             raise_on_err=False)
         var = api.get_archive(archive_name)
 
-        assert testval == var.metadata[
+        assert testval == var.get_metadata()[
             'testval'], "Test archive was incorrectly updated!"
 
         var.update_metadata({'testval': 'a different test value'})
 
-        assert var.metadata[
+        assert var.get_metadata()[
             'testval'] == 'a different test value', "Test archive was not updated!"
 
         # Test archive deletion