Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precip unit conversion to clean-cmip6, pin dev steps to v0.4.0 release #121

Merged
merged 3 commits into from
Jul 13, 2021

Conversation

brews
Copy link
Member

@brews brews commented Jul 9, 2021

This PR changes the CMIP6 cleaning workflow so that it checks precipitation units and performs a basic unit conversion if needed.

This PR also takes Argo workflow stages using dodola's floating dev tag and pins them to use the recent v0.4.0 release. This should keep the stages from unintentionally breaking from package updates, etc. in the container.

@brews brews self-assigned this Jul 9, 2021
@brews brews changed the title Pin cleaning workflow dev steps to v0.4.0 release Add precip unit conversion to clean-cmip6, pin dev steps to v0.4.0 release Jul 9, 2021
@brews
Copy link
Member Author

brews commented Jul 9, 2021

Ran this through a workflow to test things out.
The ERA5 cleaning workflow was clean-era5-dev-8v77n. It ran without issue.

The CMIP6 cleaning workflow was clean-cmip6-dev-l6x8n. It's hitting an out-of-memory error when cleaning precipitation. Specifically, it hits the standardize-cmip6 template and running dodola cleancmip6 ... (using downscalecmip6.azurecr.io/dodola:0.4.0) and this leads it to run out of memory.

Seems like the dodola cleancmip6 in the v0.4.0 update has most (or all) of the zarr store read into memory at once when the precip data undergoes its unit conversion, @dgergel.

I don't think it's a change in the input data because the raw data is unchanged from the last time we ran a clean-cmip6 workflow step.

@brews
Copy link
Member Author

brews commented Jul 13, 2021

Okay, got this running with the latest commits (see workflow clean-cmip6-dev-4hpkz for successful run). Just needed to bump memory requests a bit for precipitation cleaning steps. 👍

@brews brews marked this pull request as ready for review July 13, 2021 02:56
@brews brews requested a review from dgergel July 13, 2021 02:57
@brews brews merged commit 311361f into master Jul 13, 2021
@brews brews deleted the pin_devs branch July 13, 2021 17:42
@brews brews removed the request for review from dgergel July 13, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant