Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad release links in CHANGELOG #105

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Fix bad release links in CHANGELOG #105

merged 2 commits into from
Jul 20, 2023

Conversation

brews
Copy link
Member

@brews brews commented Jul 20, 2023

The release links were not rendering correctly in CHANGELOG.md because the links were not defined at the bottom of the file. This PR adds those links to CHANGELOG.

Now when you click on the release header it'll bring you to a github page showing the commit-by-commit diff with the previous release. This is the intended behavior.

@brews brews added the bug Something isn't working label Jul 20, 2023
@brews brews self-assigned this Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #105 (b9a7696) into main (4293eb8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   70.34%   70.34%           
=======================================
  Files          17       17           
  Lines        1878     1878           
=======================================
  Hits         1321     1321           
  Misses        557      557           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@brews
Copy link
Member Author

brews commented Jul 20, 2023

Merging this without review. It's a minor format issue that only maintainers doing releases have run into.

@brews brews merged commit 13a69bc into main Jul 20, 2023
4 checks passed
@brews brews deleted the fix_bad_links branch July 20, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant