Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: percentage of children at risk calculation, percentile consistency #43

Open
FanWangEcon opened this issue Feb 26, 2024 · 0 comments
Open

Bug: percentage of children at risk calculation, percentile consistency #43

FanWangEcon opened this issue Feb 26, 2024 · 0 comments
Assignees
@FanWangEcon
Labels
bug Something isn't working development

Comments

@FanWangEcon
Copy link
Member

FanWangEcon commented Feb 26, 2024 •
edited
Loading

Corrections for #39 and #40 .

Percentiles calculations generated different results depending on whether percentiles (of shares of days) are computed based on every 1, 2, 5, 10, or N percentile. This is due to the code using round when it should use ceil.

Code updated to reflect round to ceil changes.

image
@FanWangEcon FanWangEcon self-assigned this Feb 26, 2024
@FanWangEcon FanWangEcon added bug Something isn't working development labels Feb 26, 2024
FanWangEcon added a commit that referenced this issue Feb 26, 2024
@FanWangEcon
Code correction round to ceil for #43
e816a84 
- Share of time percentile consistency correction
- Updating results for at risk for #39 and #40.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FanWangEcon FanWangEcon

Labels
bug Something isn't working development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FanWangEcon