Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Text search and filter search not independent in UI #365

Open
VeckoTheGecko opened this issue Nov 20, 2023 · 1 comment · May be fixed by #366
Open

[BUG] Text search and filter search not independent in UI #365

VeckoTheGecko opened this issue Nov 20, 2023 · 1 comment · May be fixed by #366
Assignees
@VeckoTheGecko
Labels
bug Something on the website isn't working coding Change that requires coding good first issue Good for new developers

Comments

@VeckoTheGecko
Copy link
Collaborator

Describe the bug
Free text search and filter tag search operate completely independently, but this isn't clear in the UI. Text searching doesn't clear the tags in the UI, and tag searching doesn't clear the search box. Clearing these would make things cleaner (especially for #361 with the URLs).

To Reproduce
Steps to reproduce the bug:

  1. Go to the resources page
  2. Make a text search, then make a tag search.
  3. Note the text search query wasn't cleared, but also has no bearing on the displayed resources.
  4. Make a tag search, then make a text search.
  5. Note the tag search query wasn't cleared, but also has no bearing on the displayed resources.

Expected behavior
Clear tags when doing text search, clear search term when doing tag search.

Additional comments
Open to discussion on this.
@VeckoTheGecko VeckoTheGecko added bug Something on the website isn't working good first issue Good for new developers coding Change that requires coding labels Nov 20, 2023
@VeckoTheGecko VeckoTheGecko self-assigned this Nov 20, 2023
VeckoTheGecko added a commit that referenced this issue Nov 20, 2023
@VeckoTheGecko
Fixes #365 (with visual glitch)
036b5ed 
For some reason, programmatically editing the filterObject doesn't reflect in the UI until the next screen refresh.
@VeckoTheGecko VeckoTheGecko linked a pull request Nov 20, 2023 that will close this issue
Draft
@dmlb
Copy link
Contributor

dmlb commented Nov 23, 2023

was wondering about this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VeckoTheGecko VeckoTheGecko

Labels
bug Something on the website isn't working coding Change that requires coding good first issue Good for new developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch text search and filter search not independent in UI ClimateTown/knowledge-hub
2 participants
@dmlb @VeckoTheGecko