Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring: Make iso_code3 code visible at HistoricalEmissions downloaded file #1663

Merged
merged 2 commits into from
Jun 9, 2023
Merged

refactoring: Make iso_code3 code visible at HistoricalEmissions downloaded file #1663

merged 2 commits into from
Jun 9, 2023

Conversation

martintomas
Copy link
Collaborator

@martintomas martintomas commented Jun 8, 2023 •
edited
Loading

This PR adds ISO to HistoricalEmissions downloaded file.

https://basecamp.com/1756858/projects/13795275/todos/479334083

@martintomas martintomas requested a review from agnessa June 8, 2023 09:37
@martintomas martintomas self-assigned this Jun 8, 2023
@what-the-diff
Copy link

what-the-diff bot commented Jun 8, 2023

PR Summary

  • Column 'iso_code3' now visible
    The updated code makes the 'iso_code3' column visible to users, enhancing the information displayed.

@martintomas martintomas closed this Jun 8, 2023
@martintomas martintomas reopened this Jun 8, 2023
@martintomas martintomas changed the title refactoring: Make iso_code3 code visible at HistoricalEmissions tables and downloaded file refactoring: Make iso_code3 code visible at HistoricalEmissions downloaded file Jun 8, 2023
agnessa
agnessa approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@agnessa agnessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, that takes me back, I forgot we had a column configuration :)

@martintomas martintomas merged commit 299ef0c into develop Jun 9, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agnessa agnessa agnessa approved these changes

Assignees

@martintomas martintomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martintomas @agnessa