-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NDC Enhancement page crashing/not loading #1667
Conversation
…ancementsMap component
…g the page entirely
PR Summary
|
56e8d64
to
8aa2e92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! Check my comment
@@ -296,7 +296,7 @@ export const getPreviousComparisonCountryValues = createSelector( | |||
[getPreviousComparisonIndicators, getISOCountries], | |||
(previousComparisonIndicators, isos) => { | |||
if (!previousComparisonIndicators) return null; | |||
const previousComparisonCountryValues = {}; | |||
const previousComparisonCountryValues = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an object. We are adding attributes to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching that.
… NDCSEnhancementsMap component" This reverts commit 116205c.
Description
This PR fixes the "NDC Enhancement Tracker" page crashing when the user visited Explore NDCS first.
It also includes some minor fixes to address some of the console errors found during the debugging process, as well as a couple tweaks in an attempt to make it so that similar issues don't crash the page in its entirely.