New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/flagship detail page #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just two small doubts ⬇️
import React, { PureComponent } from 'react'; | ||
import PropTypes from 'prop-types'; | ||
import kebabCase from 'lodash/kebabCase'; | ||
// import styles from './flagship-buttons-styles.scss'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the comment pls
key={route.label || route.path} | ||
to={route.link || route.path} | ||
activeClassName={styles.active} | ||
onTouchStart={undefined} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are those necessary? (I mean passing undefined
)
I removed the comment. The onTouchStart are there because of a warning. I will check it in the next PR. Thanks! |
PR for the Flagship detail page:
Note: There is some data missing. WRI has been notified