-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connects to #914 kl progress bar style #984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Move calculated Pathogenicity of title row in progress bar 2. Add circle labels B and P
Merged #914. Nice teamwork @jimmyzhen and @kgliu0101 |
[pls ignore: comment added only to refresh PR display on waffle] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies layout of progress bar and does not change functionality of pathogenicity calculator.
Compared to the layout in R7alpha2, changes in this PR includes:
Important Code changes
src/clincoded/static/components/variant_central/interpretation/shared/calculator.js
:TestCalculator
. This class was temporarily used for testing and is not necessary any longer.calculatePathogenicity
as a internal function in classPathogenicityCalculator
.render
and use Bootstrap grid system to handle layout change.src/clincoded/static/scss/clincoded/modules/_curator.scss
:src/clincoded/static/scss/fontawesome/_icons.scss
:Steps to Test the Layout
Save and View Evidence
, and then clickStart a New Interpretation
button. Expect to see the progress bra as:BA1
to 'Met' and then clickSave
.BP4
toMet
, changeBP1
toBP1_Strong
and clickSave
.PVS1
toMet
and clickSave
.PS4
toMet
and clickSave
, changePP1
toMet
and clickSave
, changePM6
toMet
and clickSave
.End of Test