Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add snv and sv variant filteration for loqusdb and swegen #1029

Merged
merged 4 commits into from Nov 28, 2022

Conversation

khurrammaqbool
Copy link
Contributor

This PR:

Added: Variant filteration for loqusdb and swegen, snv and snv

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 99.25% // Head: 99.25% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (13d8ff1) compared to base (4a96931).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1029   +/-   ##
========================================
  Coverage    99.25%   99.25%           
========================================
  Files           28       28           
  Lines         1747     1751    +4     
========================================
+ Hits          1734     1738    +4     
  Misses          13       13           
Flag Coverage Δ
unittests 99.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
BALSAMIC/commands/config/case.py 96.96% <100.00%> (-0.05%) ⬇️
BALSAMIC/constants/variant_filters.py 100.00% <100.00%> (ø)
BALSAMIC/utils/models.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 💯

@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khurrammaqbool khurrammaqbool merged commit 1901e0a into develop Nov 28, 2022
@khurrammaqbool khurrammaqbool deleted the add/variant_filters branch November 28, 2022 17:04
@khurrammaqbool khurrammaqbool mentioned this pull request Dec 5, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants