Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove Balsamic container #1230

Merged
merged 1 commit into from Aug 16, 2023
Merged

refactor: Remove Balsamic container #1230

merged 1 commit into from Aug 16, 2023

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Aug 16, 2023

This PR:

#1225 was force pushed by mistake. After reverting to a previous commit version, this is to recover the lost PR: #1220

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym requested a review from a team August 16, 2023 15:31
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (99fe9f2) 99.42% compared to head (1e88757) 99.42%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1230      +/-   ##
===========================================
- Coverage    99.42%   99.42%   -0.01%     
===========================================
  Files           41       41              
  Lines         1917     1916       -1     
===========================================
- Hits          1906     1905       -1     
  Misses          11       11              
Flag Coverage Δ
unittests 99.42% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
BALSAMIC/constants/cache.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivadym ivadym merged commit 1066676 into develop Aug 16, 2023
21 checks passed
@ivadym ivadym deleted the remove-balsamic branch August 16, 2023 15:41
@ivadym ivadym mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant