Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added contributors #1237

Merged
merged 3 commits into from Aug 25, 2023
Merged

docs: Added contributors #1237

merged 3 commits into from Aug 25, 2023

Conversation

pbiology
Copy link
Contributor

This PR:

Fixed: Added some missing contributors to the README

@pbiology pbiology requested a review from a team as a code owner August 24, 2023 07:29
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2aa6988) 99.42% compared to head (bdd1847) 99.42%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1237   +/-   ##
========================================
  Coverage    99.42%   99.42%           
========================================
  Files           41       41           
  Lines         1926     1926           
========================================
  Hits          1915     1915           
  Misses          11       11           
Flag Coverage Δ
unittests 99.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbiology pbiology changed the title Added contributors docs: Added contributors Aug 24, 2023
Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please for next time, consider dividing this enormous PR up into separate ones to make reviewing easier 😓 One per name, for instance. But it looks good! I approve! 👍
🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@pbiology pbiology merged commit a26302d into develop Aug 25, 2023
10 checks passed
@pbiology pbiology deleted the add_contribs branch August 25, 2023 07:37
@ivadym ivadym mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants